Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: block param is not aligned with go-ethereum in debug_traceCall #391

Merged
merged 9 commits into from
Jan 11, 2024
Merged

Problem: block param is not aligned with go-ethereum in debug_traceCall #391

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
85b292c
Problem: block param is not aligned with go-ethereum in debug_traceCall
mmsqe Jan 5, 2024
6a4eb84
test_tracecall_insufficient_funds
mmsqe Jan 5, 2024
3559e06
test_debug_tracecall_call_tracer
mmsqe Jan 5, 2024
7a471cb
test_debug_tracecall_state_overrides
mmsqe Jan 5, 2024
82531ee
test_tracecall_struct_tracer
mmsqe Jan 5, 2024
ed18a4e
test_custom_js_tracers
mmsqe Jan 5, 2024
b325829
test_tracecall_prestate_tracer
mmsqe Jan 5, 2024
d2ddc1f
Update CHANGELOG.md
mmsqe Jan 8, 2024
986a4e1
Apply suggestions from code review
mmsqe Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (config) [#365](https://github.com/crypto-org-chain/ethermint/pull/365) Avoid redundant parse chainID from gensis when start server.
* (rpc) [#382](https://github.com/crypto-org-chain/ethermint/pull/382) Align tracer config with go-ethereum.
* (rpc) [#386](https://github.com/crypto-org-chain/ethermint/pull/386) Cleanup unused cancel function in filter.
* (rpc) [#388](https://github.com/crypto-org-chain/ethermint/pull/388) Avoid out of bound panic when error message.
* (rpc) [#388](https://github.com/crypto-org-chain/ethermint/pull/388) Avoid out of bound panic when error message.
* (rpc) [#](https://github.com/crypto-org-chain/ethermint/pull/) Align block param with go-ethereum in debug_traceCall.
mmsqe marked this conversation as resolved.
Show resolved Hide resolved

### Improvements

Expand Down
2 changes: 1 addition & 1 deletion rpc/backend/tracing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ func (b *Backend) TraceCall(
}

// minus one to get the context of block beginning
contextHeight := blk.Block.Height - 1
contextHeight := blk.Block.Height
mmsqe marked this conversation as resolved.
Show resolved Hide resolved
if contextHeight < 1 {
// 0 is a special value in `ContextWithHeight`
contextHeight = 1
Expand Down
4 changes: 4 additions & 0 deletions tests/integration_tests/expected_constants.py
View file
Open in desktop

Large diffs are not rendered by default.

Loading
Loading