Problem: state overrides are not supported in eth_call #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: #368 Solution: - add the feature
yihuang
commented
Oct 26, 2023
Signed-off-by: yihuang <huang@crypto.com>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+102
to
+104
| for key, value := range *account.StateDiff { | ||
| db.SetState(addr, key, value) | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
Comment on lines
+80
to
+106
| for addr, account := range *diff { | ||
| // Override account nonce. | ||
| if account.Nonce != nil { | ||
| db.SetNonce(addr, uint64(*account.Nonce)) | ||
| } | ||
| // Override account(contract) code. | ||
| if account.Code != nil { | ||
| db.SetCode(addr, *account.Code) | ||
| } | ||
| // Override account balance. | ||
| if account.Balance != nil { | ||
| db.SetBalance(addr, (*big.Int)(*account.Balance)) | ||
| } | ||
| if account.State != nil && account.StateDiff != nil { | ||
| return fmt.Errorf("account %s has both 'state' and 'stateDiff'", addr.Hex()) | ||
| } | ||
| // Replace entire state if caller requires. | ||
| if account.State != nil { | ||
| db.SetStorage(addr, *account.State) | ||
| } | ||
| // Apply state diff into specified accounts. | ||
| if account.StateDiff != nil { | ||
| for key, value := range *account.StateDiff { | ||
| db.SetState(addr, key, value) | ||
| } | ||
| } | ||
| } |
Check failure
Code scanning / gosec
the value in the range statement should be _ unless copying a map: want: for key := range m Error
mmsqe
reviewed
Oct 27, 2023
Signed-off-by: mmsqe <mavis@crypto.com>
mmsqe
reviewed
Oct 27, 2023
mmsqe
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #368
Solution:
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)