Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: changeset verify command return wrong app-hash on old blocks #985

Merged
merged 12 commits into from
Apr 20, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 20, 2023

Solution:

  • skip the stores who are added after the target version

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner April 20, 2023 06:47
@yihuang yihuang requested review from devashishdxt and leejw51crypto and removed request for a team April 20, 2023 06:47
@yihuang yihuang added the backport/v1.0.x backport to release/v1.0.x label Apr 20, 2023
CHANGELOG.md Outdated Show resolved Hide resolved
versiondb/client/verify.go Fixed Show fixed Hide fixed
Solution:
- skip the stores who are added after the target version
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang requested a review from mmsqe April 20, 2023 06:57
versiondb/client/verify.go Fixed Show fixed Hide fixed
@yihuang yihuang enabled auto-merge (squash) April 20, 2023 07:09
versiondb/client/verify.go Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
versiondb/client/verify.go Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@@ -208,6 +202,10 @@
}
// set the initial version for the store
initialVersion := filesWithVersion[0].Version
if targetVersion > 0 && initialVersion > uint64(targetVersion) {

Check failure

Code scanning / gosec

Potential integer overflow by integer type conversion

Potential integer overflow by integer type conversion
@yihuang yihuang merged commit b9d5761 into crypto-org-chain:main Apr 20, 2023
@yihuang yihuang deleted the fix-verify branch April 20, 2023 16:00
yihuang added a commit to yihuang/cronos that referenced this pull request Apr 21, 2023
…crypto-org-chain#985)

* Problem: changeset verify command return wrong app-hash on old blocks

Solution:
- skip the stores who are added after the target version

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

---------

Signed-off-by: yihuang <huang@crypto.com>
yihuang added a commit that referenced this pull request Apr 21, 2023
…#985) (#993)

* Problem: changeset verify command return wrong app-hash on old blocks

Solution:
- skip the stores who are added after the target version

* Update CHANGELOG.md



---------

Signed-off-by: yihuang <huang@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v1.0.x backport to release/v1.0.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants