Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: sdk v0.46.11 is not used #909

Merged
merged 10 commits into from
Mar 6, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 6, 2023

Solution:

  • update sdk/tendermint/ethermint dependencies
  • patch cometbft-db to use grocksdb
  • still need to replace tm-db because of indirect dependencies
  • prepare v1.0.5 release in this PR.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- update sdk/tendermint/ethermint dependencies
- patch cometbft-db to use grocksdb
- still need to replace tm-db because of indirect dependencies
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
go.mod Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as ready for review March 6, 2023 03:49
@yihuang yihuang requested a review from a team as a code owner March 6, 2023 03:49
@yihuang yihuang requested review from JayT106 and thomas-nguy and removed request for a team March 6, 2023 03:49
@yihuang yihuang requested a review from mmsqe March 6, 2023 04:04
@yihuang yihuang requested a review from tomtau March 6, 2023 04:05
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only date format need update

Co-authored-by: mmsqe <tqd0800210105@gmail.com>
Signed-off-by: yihuang <huang@crypto.com>
@yihuang
Copy link
Collaborator Author

yihuang commented Mar 6, 2023

only date format need update

yeah, fixed, thanks.

Copy link
Contributor

@calvinaco calvinaco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking Cosmos SDK v0.46.11 CHANGELOG
https://github.com/cosmos/cosmos-sdk/blob/v0.46.11/CHANGELOG.md

Want to check if this store change is potentially breaking or not?
cosmos/cosmos-sdk#14410

@yihuang
Copy link
Collaborator Author

yihuang commented Mar 6, 2023

Checking Cosmos SDK v0.46.11 CHANGELOG https://github.com/cosmos/cosmos-sdk/blob/v0.46.11/CHANGELOG.md

Want to check if this store change is potentially breaking or not? cosmos/cosmos-sdk#14410

should be non-breaking, we had the uneven case in some nodes before, which eventually manifested as app-hash mismatch, but not in the chain itself. in the future those cases (if ever happens again) will be revealed ealier.

go.mod Show resolved Hide resolved
@yihuang yihuang requested a review from calvinaco March 6, 2023 04:35
@yihuang yihuang enabled auto-merge (squash) March 6, 2023 06:08
@yihuang yihuang merged commit 65db56d into crypto-org-chain:release/v1.0.x Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants