Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: fix mistake on acknowledgement error in ibc middleware #611

Merged
merged 2 commits into from
Aug 2, 2022
Merged

Problem: fix mistake on acknowledgement error in ibc middleware #611

merged 2 commits into from
Aug 2, 2022

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

The error is nil in case of AcknowledgementError

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner August 2, 2022 08:37
@thomas-nguy thomas-nguy requested review from JayT106, adu-crypto and yihuang and removed request for a team August 2, 2022 08:37
yihuang
yihuang approved these changes Aug 2, 2022
View reviewed changes
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomas-nguy
Copy link
Collaborator Author

@yihuang may need to port to 0.7.1

@thomas-nguy
Copy link
Collaborator Author

should be verified by #606

@yihuang
Copy link
Collaborator

yihuang commented Aug 2, 2022

@yihuang may need to port to 0.7.1

but this should be considered as a breaking change?

yihuang
yihuang reviewed Aug 2, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@thomas-nguy thomas-nguy force-pushed the thomas/fix-error-ibc-middleware branch from 8264493 to 4abe5b6 Compare August 2, 2022 08:48
@yihuang yihuang merged commit bc88848 into crypto-org-chain:main Aug 2, 2022
calvinaco pushed a commit to calvinaco/cronos that referenced this pull request Aug 3, 2022
@thomas-nguy @calvinaco
Problem: fix mistake on acknowledgement error in ibc middleware (cryp…
e5b3d8a 
…to-org-chain#611)

* fix mistake on ibc middleware

* add changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang yihuang approved these changes

@adu-crypto adu-crypto adu-crypto approved these changes

@JayT106 JayT106 Awaiting requested review from JayT106 JayT106 is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thomas-nguy @yihuang @adu-crypto