Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: testnet nodes can't switch to later 0.7.0 releases #454

Merged
merged 2 commits into from
May 4, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 4, 2022

Closes: #453
Solution:

  • keep the latest testnet upgrade handler

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Closes: crypto-org-chain#453
Solution:
- keep the latest testnet upgrade handler
@yihuang yihuang requested a review from a team as a code owner May 4, 2022 09:44
@yihuang yihuang requested review from devashishdxt and adu-crypto and removed request for a team May 4, 2022 09:44
CHANGELOG.md Outdated Show resolved Hide resolved
@yihuang yihuang marked this pull request as draft May 4, 2022 09:45
@yihuang
Copy link
Collaborator Author

yihuang commented May 4, 2022

wait for someone to try on testnet.

@yihuang yihuang changed the base branch from main to release/v0.7.x May 4, 2022 09:45
@@ -727,6 +727,15 @@ func New(
return updatedVM, nil
})

// this upgrade is for breaking bug fixes on testnet
Copy link
Collaborator Author

@yihuang yihuang May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's necessary for current testnet nodes(on 0.7.0-rc3) to switch to recent 0.7.0 binaries directly.

@yihuang yihuang marked this pull request as ready for review May 4, 2022 10:37
@yihuang
Copy link
Collaborator Author

yihuang commented May 4, 2022

wait for someone to try on testnet.

verified manually on a testnet node.

@yihuang yihuang merged commit b193a0e into crypto-org-chain:release/v0.7.x May 4, 2022
@yihuang yihuang deleted the release/v0.7.x branch May 4, 2022 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem: testnet nodes can't upgrade to final 0.7.0 release
2 participants