Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: recent bug fixes on ethermint not used #378

Merged
merged 3 commits into from
Mar 9, 2022
Merged

Problem: recent bug fixes on ethermint not used #378

merged 3 commits into from
Mar 9, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Mar 7, 2022 •
edited
Loading

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang
Problem: recent bug fixes on ethermint not used
ae2a101 
- [Quick fix for eth_feeHistory when reward is nil](evmos/ethermint#975)
- [Add buffer to eth_gasPrice response](evmos/ethermint#968)
- [Fix GasMeter reset in AnteHandler, aka. return correct gasWanted to tendermint](evmos/ethermint#964)
  modified to only fix checkTx mode to avoid breaking consensus.
@yihuang yihuang requested a review from a team as a code owner March 7, 2022 02:05
@yihuang yihuang requested review from devashishdxt and adu-crypto and removed request for a team March 7, 2022 02:05
@codecov
Copy link

codecov bot commented Mar 7, 2022 •
edited
Loading

Codecov Report

Merging #378 (806435c) into main (3ea70c5) will increase coverage by 19.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #378       +/-   ##
===========================================
+ Coverage   21.51%   41.06%   +19.54%     
===========================================
  Files          27       30        +3     
  Lines        1729     1505      -224     
===========================================
+ Hits          372      618      +246     
+ Misses       1324      841      -483     
- Partials       33       46       +13
Impacted Files Coverage Δ
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 58.00% <ø> (+6.27%) ⬆️
x/cronos/keeper/evm_hooks.go 80.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
x/cronos/keeper/ibc_hooks.go 50.00% <ø> (-8.83%) ⬇️
x/cronos/keeper/keeper.go 64.89% <ø> (-29.45%) ⬇️
... and 28 more

yihuang
yihuang commented Mar 7, 2022
View reviewed changes
go.mod Outdated Show resolved Hide resolved
@landanhu
Copy link
Contributor

landanhu commented Mar 7, 2022

what about evmos/ethermint#955?

@yihuang
Copy link
Collaborator Author

yihuang commented Mar 7, 2022

what about tharsis/ethermint#955?

it's already included by this PR: #370

This was referenced Mar 7, 2022
Closed
Merged
yihuang
yihuang commented Mar 8, 2022
View reviewed changes
go.mod
@@ -164,7 +164,7 @@ replace (
// See https://github.com/tecbot/gorocksdb/pull/216
github.com/tecbot/gorocksdb => github.com/cosmos/gorocksdb v1.1.1

github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-6.0.20220301081024-4ec8b052c769
github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.10.0-alpha1-cronos-7
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/crypto-org-chain/ethermint/compare/4ec8b052c769...v0.10.0-alpha1-cronos-7?expand=1

thomas-nguy
thomas-nguy approved these changes Mar 9, 2022
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks okay 👍

@yihuang yihuang merged commit c5de3dd into crypto-org-chain:main Mar 9, 2022
@yihuang yihuang deleted the port-bug-fixes branch March 9, 2022 01:56
@yihuang yihuang mentioned this pull request Mar 9, 2022
Closed
@coderabbitai coderabbitai bot mentioned this pull request Apr 19, 2024
Merged
13 tasks
This was referenced Apr 26, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

@adu-crypto adu-crypto Awaiting requested review from adu-crypto adu-crypto is a code owner automatically assigned from crypto-org-chain/cronos-dev

@crypto-facs crypto-facs Awaiting requested review from crypto-facs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yihuang @landanhu @thomas-nguy