Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: 0.70-rc1 testnet does not support eth_call for blocks prior to upgrade #329

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Problem: 0.70-rc1 testnet does not support eth_call for blocks prior to upgrade #329

merged 2 commits into from
Feb 10, 2022

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Feb 9, 2022 •
edited
Loading

Closes: #327
Solution:

  • fix base fee check logic in ethermint.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner February 9, 2022 06:28
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team February 9, 2022 06:28
@yihuang
Problem: 0.70-rc1 testnet does not support eth_call for blocks prior …
ce5d6d2 
…to upgrade

Closes: crypto-org-chain#327

Solution:
- fix base fee check logic in ethermint.
@codecov
Copy link

codecov bot commented Feb 9, 2022 •
edited
Loading

Codecov Report

Merging #329 (298592e) into main (3ea70c5) will increase coverage by 19.54%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #329       +/-   ##
===========================================
+ Coverage   21.51%   41.06%   +19.54%     
===========================================
  Files          27       30        +3     
  Lines        1729     1505      -224     
===========================================
+ Hits          372      618      +246     
+ Misses       1324      841      -483     
- Partials       33       46       +13
Impacted Files Coverage Δ
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 58.00% <ø> (+6.27%) ⬆️
x/cronos/keeper/evm_hooks.go 80.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
x/cronos/keeper/ibc_hooks.go 50.00% <ø> (-8.83%) ⬇️
x/cronos/keeper/keeper.go 64.89% <ø> (-29.45%) ⬇️
... and 28 more

@thomas-nguy
Copy link
Collaborator

thomas-nguy commented Feb 9, 2022 •
edited
Loading

Diff

crypto-org-chain/ethermint@v0.10.0-alpha1-cronos-3...v0.10.0-alpha1-cronos-4

@yihuang yihuang merged commit 0767552 into crypto-org-chain:main Feb 10, 2022
@yihuang yihuang deleted the fix-eth-call-on-old-blocks branch February 10, 2022 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.70-rc1 testnet does not support eth_call for blocks prior to upgrade
2 participants
@yihuang @thomas-nguy