Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: app is sealed before upgrade handler is called #287

Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Solution: Move the upgrade handler before sealing the app

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner January 3, 2022 10:11
@thomas-nguy thomas-nguy requested review from yihuang and calvinaco and removed request for a team January 3, 2022 10:11
@thomas-nguy thomas-nguy changed the title Problem: app is sealed before upgrade handler Problem: app is sealed before upgrade handler is called Jan 3, 2022
@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #287 (ae29be4) into main (3ea70c5) will increase coverage by 19.59%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #287       +/-   ##
===========================================
+ Coverage   21.51%   41.11%   +19.59%     
===========================================
  Files          27       30        +3     
  Lines        1729     1508      -221     
===========================================
+ Hits          372      620      +248     
+ Misses       1324      842      -482     
- Partials       33       46       +13     
Impacted Files Coverage Δ
x/cronos/genesis.go 61.53% <ø> (-38.47%) ⬇️
x/cronos/handler.go 100.00% <ø> (ø)
x/cronos/keeper/evm.go 56.31% <ø> (+4.58%) ⬆️
x/cronos/keeper/evm_hooks.go 90.00% <ø> (ø)
x/cronos/keeper/evm_log_handlers.go 83.50% <ø> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <ø> (ø)
x/cronos/keeper/grpc_query.go 0.00% <ø> (ø)
x/cronos/keeper/ibc.go 83.20% <ø> (+5.01%) ⬆️
x/cronos/keeper/ibc_hooks.go 50.00% <ø> (-8.83%) ⬇️
x/cronos/keeper/keeper.go 64.89% <ø> (-29.45%) ⬇️
... and 28 more

Copy link
Contributor

@tomtau tomtau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm -- one thing is the integration test, but there's a separate issue for it: #247

@thomas-nguy thomas-nguy merged commit 19fd84d into crypto-org-chain:main Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants