Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump ethermint v0.7.1 #169

Merged

Conversation

thomas-nguy
Copy link
Collaborator

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

Bump ethermint version

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@thomas-nguy thomas-nguy requested a review from a team as a code owner October 12, 2021 10:40
@thomas-nguy thomas-nguy requested review from yihuang and devashishdxt and removed request for a team October 12, 2021 10:40
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #169 (9cb43d8) into main (3ea70c5) will increase coverage by 4.90%.
The diff coverage is 48.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   21.51%   26.42%   +4.90%     
==========================================
  Files          27       34       +7     
  Lines        1729     2426     +697     
==========================================
+ Hits          372      641     +269     
- Misses       1324     1737     +413     
- Partials       33       48      +15     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 5.00% <0.00%> (-1.46%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <0.00%> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 20.22% <ø> (+20.22%) ⬆️
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cc161...9cb43d8. Read the comment docs.

@thomas-nguy
Copy link
Collaborator Author

still having issue to update gomod2nix with my vpn

@yihuang
Copy link
Collaborator

yihuang commented Oct 12, 2021

still having issue to update gomod2nix with my vpn

One idea is we can change the workflow to upload the artifact when dirty, similar to this: https://github.com/crypto-org-chain/cronos/blob/main/.github/workflows/test.yml#L28. So you can download the generated file and commit again.

go.mod Outdated
@@ -41,5 +41,5 @@ replace github.com/peggyjv/gravity-bridge/module => github.com/crypto-org-chain/

replace github.com/cosmos/iavl => github.com/cosmos/iavl v0.17.1

// FIXME: https://github.com/crypto-org-chain/ethermint/tree/cronos2
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.4.2-0.20211004101819-7b5449f36cc8
replace github.com/tharsis/ethermint => github.com/crypto-org-chain/ethermint v0.7.1-patched
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems the only change is https://github.com/crypto-org-chain/ethermint/commits/thomas/v0.7.1-patched the go-ethereum -- I think that isn't needed, it's enough just to have the line to replace go-ethereum here (it'd use it in all dependencies, i.e. it's fine to use github.com/tharsis/ethermint without replacing ethermint)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, updated

@thomas-nguy thomas-nguy changed the title Bump ethermint v0.7.1-patched Bump ethermint v0.7.1 Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants