Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: non-stable Gravity Bridge module related functionality #168

Merged
merged 2 commits into from
Oct 13, 2021

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Oct 12, 2021

Solution: drafted ADR to disable Gravity Bridge at genesis

Solution: drafted ADR to disable Gravity Bridge at genesis
@codecov
Copy link

codecov bot commented Oct 12, 2021

Codecov Report

Merging #168 (390a4ff) into main (3ea70c5) will increase coverage by 4.91%.
The diff coverage is 48.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #168      +/-   ##
==========================================
+ Coverage   21.51%   26.43%   +4.91%     
==========================================
  Files          27       34       +7     
  Lines        1729     2425     +696     
==========================================
+ Hits          372      641     +269     
- Misses       1324     1736     +412     
- Partials       33       48      +15     
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/gravity_hooks.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 5.00% <0.00%> (-1.46%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <0.00%> (ø)
x/cronos/types/events.go 0.00% <ø> (ø)
x/cronos/types/messages.go 20.22% <ø> (+20.22%) ⬆️
x/cronos/types/params.go 57.35% <ø> (+3.78%) ⬆️
... and 21 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa30b60...390a4ff. Read the comment docs.

@yihuang yihuang mentioned this pull request Oct 13, 2021
13 tasks
Copy link
Collaborator

@yihuang yihuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tomtau tomtau merged commit 51db712 into crypto-org-chain:main Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants