Problem: can't use more parallelism than GOMAXPROCS

[yihuang]

Solution:

• take the min of GOMAXPROCS and NumCPU

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Improved default parallelism settings for enhanced performance in the block-stm executor.
  • Introduced a new function for better resource management during execution.

• Bug Fixes

  • Updated dependencies to the latest version, which may include performance improvements and bug fixes.

• Documentation

  • Changelog updated to reflect recent changes and improvements.

• Chores

  • Specified exact Go version in workflow configuration for improved consistency and stability.
  • Removed deprecated script from the benchmark project.

[coderabbitai]

Walkthrough

The pull request introduces changes to optimize the default parallelism settings of the block-stm executor. It updates the changelog to reflect these improvements, adds a new function maxParallelism() in app.go to determine the number of workers, and modifies the worker allocation strategy to use this new function. Additionally, the dependency version for github.com/crypto-org-chain/go-block-stm is updated in both go.mod and gomod2nix.toml, indicating an upgrade to the module.

Changes

File	Change Summary
CHANGELOG.md	Added a section for "UNRELEASED" detailing improvements to block-stm's default parallelism and the introduction of maxParallelism() function.
app/app.go	Modified worker allocation logic in New function to use maxParallelism() for determining the number of workers, enhancing code readability.
go.mod	Updated version of github.com/crypto-org-chain/go-block-stm from v0.0.0-20240912024944-1cd89976aa5e to v0.0.0-20240919080136-6c49aef68716.
gomod2nix.toml	Updated version and hash for github.com/crypto-org-chain/go-block-stm to reflect the new version and corresponding hash change.
.github/workflows/lint.yml	Changed Go version from ^1.22.0 to 1.22.7 for consistency in the build process.
testground/benchmark/pyproject.toml	Removed testground-testcase script from the [tool.poetry.scripts] section, indicating a shift in focus.

Possibly related PRs

• Problem: block-stm has bad worst case performance #1570: This PR introduces a pre-estimate block-stm option that enhances performance, which is related to the changes in the main PR that also focus on optimizing the block-stm's parallelism settings.
• Problem: pre-estimate runs sequentially #1571: This PR modifies the BlockSTMPreEstimate constant, which is directly related to the changes in the main PR that involve the management of parallelism in block-stm execution.

Suggested reviewers

• devashishdxt
• mmsqe
• thomas-nguy

🐰 In the realm of code so bright,
A rabbit hops with pure delight.
Parallelism now optimized,
Workers managed, well-advised.
With each change, we leap and bound,
In harmony, our code is found! 🌟

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between f98d2d2 and 8a35414.

Files selected for processing (2)

• .github/workflows/lint.yml (1 hunks)
• testground/benchmark/pyproject.toml (0 hunks)

Files not reviewed due to no reviewable changes (1)

• testground/benchmark/pyproject.toml

Files skipped from review due to trivial changes (1)

• .github/workflows/lint.yml

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  -- I pushed a fix in commit <commit_id>, please review it.
  -- Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  -- @coderabbitai generate unit testing code for this file.
  -- @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  -- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  -- @coderabbitai read src/utils.ts and generate unit testing code.
  -- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  -- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.12%. Comparing base (b6c83b7) to head (8a35414).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1592       +/-   ##
===========================================
+ Coverage   15.24%   36.12%   +20.88%     
===========================================
  Files          67       97       +30     
  Lines        4874     7725     +2851     
===========================================
+ Hits          743     2791     +2048     
- Misses       4037     4585      +548     
- Partials       94      349      +255     

see 47 files with indirect coverage changes