Problem: recent rpc fixes are not included

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

crypto-org-chain/ethermint@fe3f4fd...3fabdbe

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Updated the Ethermint library to a newer version, which may include performance improvements and bug fixes.

• Bug Fixes

  • Documented a critical fix related to crash issues caused by chainID and transaction hash mismatches in the newHeads functionality.

• Documentation

  • Added a new entry in the CHANGELOG.md to enhance user awareness of recent updates and fixes.

[coderabbitai]

Walkthrough

The pull request introduces updates to the Ethermint project, including a new entry in the CHANGELOG.md to document a fix for a crash issue related to chainID and transaction hash mismatches. Additionally, the go.mod and gomod2nix.toml files are updated to reflect a newer version of the github.com/crypto-org-chain/ethermint dependency, including changes to version and hash values for integrity verification.

Changes

Files	Change Summary
CHANGELOG.md	Added entry for pull request #1569 regarding crash fix on chainID and transaction hash.
go.mod, gomod2nix.toml	Updated version of github.com/crypto-org-chain/ethermint from v0.6.1-0.20240815051559 to v0.6.1-0.20240911060243. Updated corresponding hash in gomod2nix.toml.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Ethermint
    participant GoModules

    User->>Ethermint: Initiate transaction
    Ethermint->>GoModules: Check chainID and transaction hash
    GoModules-->>Ethermint: Return validation result
    Ethermint-->>User: Confirm transaction or report error

Loading

Poem

🐇 In the meadow where bunnies play,
A fix was made, hip-hip-hooray!
Ethermint shines, no more crash,
With updates swift, we make a splash!
Hopping along, we celebrate,
Code so fine, it’s simply great! 🎉

---

Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 13360a7 and fcf36cc.

Files ignored due to path filters (1)

• go.sum is excluded by !**/*.sum

Files selected for processing (3)

• CHANGELOG.md (1 hunks)
• go.mod (1 hunks)
• gomod2nix.toml (1 hunks)

Files skipped from review due to trivial changes (2)

• CHANGELOG.md
• go.mod

Additional comments not posted (2)

gomod2nix.toml (2)

262-263: LGTM!

The changes to update the version and hash for the github.com/evmos/ethermint module are approved.

---

262-263: Verify the impact of updating the ethermint dependency.

Ensure that the changes introduced by updating the github.com/evmos/ethermint module from version v0.6.1-0.20240815051559-fe3f4fd535d7 to v0.6.1-0.20240911060243-3fabdbeba4e0 are thoroughly tested.

Confirm that the functionality dependent on this module works as expected with the newer version.

Run the following script to find usages of the github.com/evmos/ethermint module in the codebase:

Review the files that import this module and ensure the relevant functionality is covered by tests.

Verification successful

---

The ethermint module update is covered by existing tests. The test files contain references to various components of the ethermint module, indicating that the functionality dependent on this module is being tested. Ensure that these tests are comprehensive and cover all critical paths affected by the update.

• Test files with ethermint references:
  • x/cronos/handler_test.go
  • x/cronos/keeper/evm_test.go
  • x/cronos/keeper/permissions_test.go
  • x/cronos/keeper/keeper_test.go
  • x/cronos/keeper/ibc_test.go
  • app/sim_test.go
  • app/bench_test.go

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Find all imports of the `github.com/evmos/ethermint` module. 
# Expect: A list of files that import this module.

rg --type go -l $'github.com/evmos/ethermint'

Length of output: 632

---

Script:

#!/bin/bash
# Description: Search for references to `ethermint` in the identified test files to verify test coverage.

# List of test files from the previous output
test_files=(
  "x/cronos/handler_test.go"
  "x/cronos/keeper/evm_test.go"
  "x/cronos/keeper/permissions_test.go"
  "x/cronos/keeper/keeper_test.go"
  "x/cronos/keeper/ibc_test.go"
  "app/sim_test.go"
  "app/bench_test.go"
)

# Search for references to `ethermint` in these test files
for file in "${test_files[@]}"; do
  echo "Searching in $file"
  rg 'ethermint' "$file"
done

Length of output: 2002

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.12%. Comparing base (13360a7) to head (fcf36cc).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1569       +/-   ##
===========================================
+ Coverage   15.24%   36.12%   +20.88%     
===========================================
  Files          67       97       +30     
  Lines        4874     7725     +2851     
===========================================
+ Hits          743     2791     +2048     
- Misses       4037     4585      +548     
- Partials       94      349      +255     

see 47 files with indirect coverage changes