Problem: invalid chain id for signer

[mmsqe]

For more info:
crypto-org-chain/ethermint#501
https://github.com/crypto-org-chain/cronos/actions/runs/10051584712/job/27781409154

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Improved handling of chain IDs during RPC calls to prevent invalid chain ID errors, enhancing system reliability.
  • Integrated chain-specific context into API route registration for better transaction processing and query handling.

• Bug Fixes

  • Resolved an issue that caused failures in the signing process due to premature RPC calls.

• Chores

  • Updated the Ethermint library to a newer version for potential bug fixes and performance improvements.

[coderabbitai]

Walkthrough

This update enhances the system's reliability by fixing a bug related to chain ID handling during RPC calls. It improves the API route registration by incorporating chain-specific context, updates a dependency for better functionality, and reflects these changes in the build configuration files. Overall, these modifications aim to strengthen the application's performance and user experience.

Changes

Files	Change Summary
CHANGELOG.md	Added a section documenting a bug fix for handling chain IDs during RPC calls to improve reliability.
app/app.go	Modified RegisterAPIRoutes to include WithChainIDString for context-aware API functionality.
go.mod, gomod2nix.toml	Updated the version of github.com/evmos/ethermint to a newer release, including changes to version and hash.

Poem

In the garden of code, where rabbits play,
A bug was fixed, hip-hip-hooray! 🐇
With chain IDs dancing, all in a row,
API routes know where to go.
Dependencies updated, smooth as can be,
Hops of joy, for you and me! 🌼

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 36.84%. Comparing base (983a5a6) to head (18a5f35).
Report is 1 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #1520       +/-   ##
===========================================
+ Coverage   17.54%   36.84%   +19.29%     
===========================================
  Files          87      117       +30     
  Lines        5273     8124     +2851     
===========================================
+ Hits          925     2993     +2068     
- Misses       4238     4766      +528     
- Partials      110      365      +255     

see 53 files with indirect coverage changes

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 983a5a6 and 18a5f35.

Files ignored due to path filters (2)

• go.sum is excluded by !**/*.sum
• integration_tests/poetry.lock is excluded by !**/*.lock

Files selected for processing (4)

• CHANGELOG.md (1 hunks)
• app/app.go (1 hunks)
• go.mod (1 hunks)
• gomod2nix.toml (1 hunks)

Files skipped from review due to trivial changes (1)

• gomod2nix.toml

Additional comments not posted (3)

go.mod (1)

279-279: Dependency version update approved.

The version update for github.com/crypto-org-chain/ethermint aligns with the PR objectives to address the invalid chain ID issue.

CHANGELOG.md (1)

29-32: Changelog entry approved.

The new bug fix entry accurately describes the issue and the fix related to the invalid chain ID for the signer.

app/app.go (1)

1228-1228: LGTM! But verify the function usage in the codebase.

The code changes are approved.

However, ensure that all function calls to RegisterAPIRoutes are updated to include the new chain ID context.