Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: fix duplicate cache events emitted from evm hooks and wrong priority tx are not included #1308

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Feb 1, 2024

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

For more info

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • New Features

    • Enhanced event emission mechanism to avoid duplicate cache events from EVM hooks.
    • Added new validation function for integration tests to ensure data integrity.
  • Tests

    • Improved integration tests with additional checks for logs length and block height during balance changes and token transfers.

go.mod Outdated Show resolved Hide resolved
Copy link
Contributor

coderabbitai bot commented Feb 1, 2024

Walkthrough

The recent changes focus on enhancing event emission mechanisms in EVM hooks to prevent duplicate cache events. Additionally, the integration testing suite has been improved with new functions for HTTP response validation and additional checks on logs and block heights. These modifications aim to streamline testing processes and ensure the robustness of event handling.

Changes

File Path Change Summary
CHANGELOG.md Avoided duplicate cache events from EVM hooks, enhanced event emission mechanism.
integration_tests/ibc_utils.py Added assert_duplicate function for HTTP request validation; imported requests module.
integration_tests/test_ibc_rly.py Integrated assert_duplicate and added checks for log length and block height in several functions.

🐇✨
In the code's woven maze, we hop and tweak,
Fixing duplicates, a future not so bleak.
Through tests and checks, our journey's peak,
A rabbit's touch, a solution unique.
🌟🐾

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@mmsqe mmsqe marked this pull request as ready for review February 1, 2024 08:26
@mmsqe mmsqe requested a review from a team as a code owner February 1, 2024 08:26
@mmsqe mmsqe requested review from calvinaco and thomas-nguy and removed request for a team February 1, 2024 08:26
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 5

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 55cfc2f and 330d7df.
Files ignored due to path filters (3)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
  • gomod2nix.toml is excluded by: !**/*.toml
Files selected for processing (3)
  • CHANGELOG.md (1 hunks)
  • integration_tests/ibc_utils.py (2 hunks)
  • integration_tests/test_ibc_rly.py (4 hunks)
Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

integration_tests/test_ibc_rly.py Show resolved Hide resolved
integration_tests/test_ibc_rly.py Show resolved Hide resolved
integration_tests/test_ibc_rly.py Show resolved Hide resolved
integration_tests/ibc_utils.py Show resolved Hide resolved
integration_tests/ibc_utils.py Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 330d7df and 8fe18b7.
Files ignored due to path filters (3)
  • go.mod is excluded by: !**/*.mod
  • go.sum is excluded by: !**/*.sum
  • gomod2nix.toml is excluded by: !**/*.toml
Files selected for processing (1)
  • CHANGELOG.md (1 hunks)
Files skipped from review as they are similar to previous changes (1)
  • CHANGELOG.md

@mmsqe mmsqe changed the title Problem: duplicate cache events are emitted Problem: fix duplicate cache events emitted from evm hooks and wrong priority tx are not included Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants