Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: external token mapping not manageable directly #128

Merged
merged 3 commits into from
Oct 7, 2021
Merged

Problem: external token mapping not manageable directly #128

merged 3 commits into from
Oct 7, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 30, 2021 •
edited
Loading

Closes: #119

Solution:

  • add native message to update token mapping
  • add a simple ACL for it

unit tests

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

@yihuang yihuang requested a review from a team as a code owner September 30, 2021 04:24
@yihuang yihuang requested review from calvinaco and devashishdxt and removed request for a team September 30, 2021 04:24
@codecov
Copy link

codecov bot commented Sep 30, 2021 •
edited
Loading

Codecov Report

Merging #128 (c86ba0c) into main (3ea70c5) will increase coverage by 4.38%.
The diff coverage is 48.64%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #128      +/-   ##
==========================================
+ Coverage   21.51%   25.89%   +4.38%     
==========================================
  Files          27       34       +7     
  Lines        1729     2367     +638     
==========================================
+ Hits          372      613     +241     
- Misses       1324     1709     +385     
- Partials       33       45      +12
Impacted Files Coverage Δ
app/prefix.go 0.00% <0.00%> (ø)
app/test_helpers.go 0.00% <0.00%> (ø)
x/cronos/keeper/grpc_query.go 0.00% <0.00%> (ø)
x/cronos/keeper/hooks.go 0.00% <0.00%> (ø)
x/cronos/keeper/msg_server.go 5.00% <0.00%> (-1.46%) ⬇️
x/cronos/module.go 59.64% <0.00%> (-2.17%) ⬇️
x/cronos/types/codec.go 0.00% <0.00%> (ø)
x/cronos/types/query.pb.gw.go 0.00% <ø> (ø)
x/cronos/types/tracer.go 0.00% <ø> (ø)
app/app.go 4.03% <2.17%> (+0.08%) ⬆️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47ce47c...c86ba0c. Read the comment docs.

@yihuang
Problem: external token mapping not manageable directly
eb25147 
Closes: crypto-org-chain#119

Solution:
- add native message to update token mapping

unit tests

Update x/cronos/keeper/msg_server.go

fix lint

fix msgs
thomas-nguy
thomas-nguy reviewed Oct 7, 2021
View reviewed changes
docs/api/proto-docs.md
@@ -49,6 +51,7 @@ Params defines the parameters for the cronos module.
| ----- | ---- | ----- | ----------- |
| `ibc_cro_denom` | [string](#string) | | |
| `ibc_timeout` | [uint64](#uint64) | | |
| `cronos_admin` | [string](#string) | | the admin address who can update token mapping |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we want multiple admins?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure, we can do that later if wanted.

thomas-nguy
thomas-nguy approved these changes Oct 7, 2021
View reviewed changes
Copy link
Collaborator

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yihuang yihuang merged commit 781c04d into crypto-org-chain:main Oct 7, 2021
@yihuang yihuang deleted the token-mapping branch October 7, 2021 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomas-nguy thomas-nguy thomas-nguy approved these changes

@calvinaco calvinaco Awaiting requested review from calvinaco calvinaco is a code owner automatically assigned from crypto-org-chain/cronos-dev

@devashishdxt devashishdxt Awaiting requested review from devashishdxt devashishdxt is a code owner automatically assigned from crypto-org-chain/cronos-dev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problem: external token mapping not manageable directly
2 participants
@yihuang @thomas-nguy