Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: upgrade with versiondb and memiavl is not tested #1205

Merged
merged 12 commits into from
Oct 16, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 12, 2023

Solution:

  • enable memiavl and versiondb in upgrade test.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- enable memiavl and versiondb in upgrade test.
@yihuang yihuang requested a review from a team as a code owner October 12, 2023 23:43
@yihuang yihuang requested review from mmsqe and calvinaco and removed request for a team October 12, 2023 23:43
Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need use newer binary in upgrade-test-package.nix right?

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 13, 2023

need use newer binary in upgrade-test-package.nix right?

yes, changed to v1.0.12.

@mmsqe mmsqe enabled auto-merge October 13, 2023 01:27
@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #1205 (a887426) into main (c47cc56) will not change coverage.
The diff coverage is 0.00%.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1205   +/-   ##
=======================================
  Coverage   36.95%   36.95%           
=======================================
  Files         115      115           
  Lines       10235    10235           
=======================================
  Hits         3782     3782           
  Misses       6080     6080           
  Partials      373      373           
Files Coverage Δ
memiavl/db.go 59.93% <0.00%> (ø)
versiondb/client/restore.go 0.00% <0.00%> (ø)

Copy link
Collaborator

@mmsqe mmsqe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update all submodules 1st, the lint error seems also relate to it

@yihuang
Copy link
Collaborator Author

yihuang commented Oct 16, 2023

should we update all submodules 1st, the lint error seems also relate to it

I see, thanks, lint error because of build failure with wrong librocksdb.

Signed-off-by: yihuang <huang@crypto.com>
@mmsqe mmsqe added this pull request to the merge queue Oct 16, 2023
Merged via the queue into crypto-org-chain:main with commit 03edb77 Oct 16, 2023
23 of 24 checks passed
@yihuang yihuang deleted the test-upgrade branch October 16, 2023 11:02
yihuang added a commit that referenced this pull request Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants