Problem: versiondb don't support restore from local snapshot #1108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to setup a pruned versiondb node, we need to restore versiondb from local snapshot. Solution: - implement a new subcommand for that.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| defer batch.Destroy() | ||
|
|
||
| var ts [TimestampSize]byte | ||
| binary.LittleEndian.PutUint64(ts[:], uint64(version)) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
| } | ||
| }() | ||
|
|
||
| return versionDB.Import(int64(height), ch) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
| return err | ||
| } | ||
|
|
||
| snapshot, chChunks, err := store.Load(height, uint32(format)) |
Check failure
Code scanning / gosec
Potential integer overflow by integer type conversion Error
yihuang
requested review from
mmsqe and
calvinaco
and removed request for
a team
yihuang
commented
Jul 25, 2023
Signed-off-by: yihuang <huang@crypto.com>
mmsqe
reviewed
Jul 25, 2023
Codecov Report
@@ Coverage Diff @@
## main #1108 +/- ##
===========================================
+ Coverage 22.24% 46.19% +23.95%
===========================================
Files 47 82 +35
Lines 3044 7386 +4342
===========================================
+ Hits 677 3412 +2735
- Misses 2300 3612 +1312
- Partials 67 362 +295
|
mmsqe
approved these changes
Jul 25, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: mmsqe <mavis@crypto.com>
Merged
via the queue into
crypto-org-chain:main
with commit Jul 26, 2023
2ec31fe
22 of 24 checks passed
13 tasks
This was referenced Apr 26, 2024
This was referenced Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to setup a pruned versiondb node, we need to restore versiondb from local snapshot.
Solution:
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make)make test)go fmt)golangci-lint run)go list -json -m all | nancy sleuth)Thank you for your code, it's appreciated! :)