Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memory leak during memiavl import #1036

Merged
merged 3 commits into from
May 24, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented May 24, 2023

Solution:

  • break up the unnesserary references

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- break up the unnesserary references
@yihuang yihuang requested a review from a team as a code owner May 24, 2023 06:48
@yihuang yihuang requested review from devashishdxt, leejw51crypto and mmsqe and removed request for a team May 24, 2023 06:48
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang enabled auto-merge May 24, 2023 06:50
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1036 (e5ac639) into main (de7e559) will increase coverage by 23.96%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1036       +/-   ##
===========================================
+ Coverage   22.43%   46.39%   +23.96%     
===========================================
  Files          50       82       +32     
  Lines        3013     6955     +3942     
===========================================
+ Hits          676     3227     +2551     
- Misses       2272     3393     +1121     
- Partials       65      335      +270     
Impacted Files Coverage Δ
memiavl/import.go 65.40% <100.00%> (ø)

... and 46 files with indirect coverage changes

memiavl/import.go Outdated Show resolved Hide resolved
Co-authored-by: mmsqe <mavis@crypto.com>
Signed-off-by: yihuang <huang@crypto.com>
@yihuang yihuang added this pull request to the merge queue May 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 24, 2023
@yihuang yihuang added this pull request to the merge queue May 24, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks May 24, 2023
@yihuang yihuang added this pull request to the merge queue May 24, 2023
Merged via the queue into crypto-org-chain:main with commit 81e9eea May 24, 2023
@yihuang yihuang deleted the memory-leak branch May 24, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants