Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: ibc relayer don't work well with default tx prioritization stretegy #634

Closed
yihuang opened this issue Aug 11, 2022 · 4 comments · Fixed by #652
Closed

Problem: ibc relayer don't work well with default tx prioritization stretegy #634

yihuang opened this issue Aug 11, 2022 · 4 comments · Fixed by #652

Comments

@yihuang
Copy link
Collaborator

yihuang commented Aug 11, 2022

Implement the workarounds. informalsystems/hermes#2350
@yihuang yihuang mentioned this issue Aug 11, 2022
Merged
13 tasks
@yihuang
Copy link
Collaborator Author

yihuang commented Aug 16, 2022 •
edited
Loading

Two solutions:

  • Using a custom TxFeeChecker on cronos to set a constant priority for IBC txs (txs that contain only IBC messages).
    • Pros: don't need to change the relayer code
    • Cons: different relayers can't have different priorities
  • Customize relayer tx building logic to include extension option ExtensionOptionDynamicFeeTx and set the max_priority_price to a constant value, set the gas_price to maxint, so it'll end up with a constant priority value.
    • Pros: different relayers can use different priorities
    • Cons: need to change relayer code (customized tx building logic)

@tomtau
Copy link
Contributor

tomtau commented Aug 16, 2022

not sure how many external relayer operators there are, but I assume they'll be running the vanilla relayer binaries without any patches and TxFeeChecker may work better?

@yihuang
Copy link
Collaborator Author

yihuang commented Aug 16, 2022

not sure how many external relayer operators there are, but I assume they'll be running the vanilla relayer binaries without any patches and TxFeeChecker may work better?

yeah, I guess that's simpler in the short term.

@tomtau
Copy link
Contributor

tomtau commented Aug 16, 2022

or if that second workaround is a normal option in one of the relayer official releases, it should be ok as well

yihuang added a commit to yihuang/cronos that referenced this issue Aug 17, 2022
@yihuang
Problem: ibc relayer don't work well with default tx prioritization s…
83daefd 
…tretegy

Closes: crypto-org-chain#634
Solution:
- set dynamic fee extension option in hermes
@yihuang yihuang mentioned this issue Aug 17, 2022
Merged
14 tasks
yihuang added a commit that referenced this issue Aug 19, 2022
@yihuang
Problem: ibc relayer don't work well with default tx prioritization s…
f4d6cf8 
…trategy (#652)

* Problem: ibc relayer don't work well with default tx prioritization stretegy

Closes: #634
Solution:
- set dynamic fee extension option in hermes

* check relayer tx fee in integration test

* Update integration_tests/configs/ibc.jsonnet

* renames
@yihuang yihuang mentioned this issue Aug 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: ibc relayer don't work well with default tx prioritization strategy yihuang/cronos
2 participants
@yihuang @tomtau