Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: no easy way to emit event from ica callback contract #1231

Closed
mmsqe opened this issue Oct 30, 2023 · 0 comments · Fixed by #1233
Closed

Problem: no easy way to emit event from ica callback contract #1231

mmsqe opened this issue Oct 30, 2023 · 0 comments · Fixed by #1233

Comments

@mmsqe
Copy link
Collaborator

mmsqe commented Oct 30, 2023

Currently only params Pack in to method, it would be helpful to support emit event to allow smart contract to subscribe on.
yihuang added a commit to yihuang/cronos that referenced this issue Oct 31, 2023
@yihuang
Problem: logs in callback contract are lost
bad0847 
Closes: crypto-org-chain#1231

Solution:
- re-emit those logs
@yihuang yihuang mentioned this issue Oct 31, 2023
Merged
13 tasks
github-merge-queue bot pushed a commit that referenced this issue Nov 2, 2023
@yihuang @mmsqe
Problem: logs in callback contract are lost (#1233)
394bce5 
* Problem: logs in callback contract are lost

Closes: #1231

Solution:
- re-emit those logs

* Update CHANGELOG.md

Signed-off-by: yihuang <huang@crypto.com>

* constant refactor

* fix getLogs

* use precompile relayer to test ica callback

* cover crc20 callbacks as well

* inject the statedb in ethermint

* simplify assert log

* test without rly precompile

* cleanup

* Revert "test without rly precompile"

This reverts commit 25c3fee.

---------

Signed-off-by: yihuang <huang@crypto.com>
Co-authored-by: mmsqe <mavis@crypto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: logs in callback contract are lost yihuang/cronos
1 participant
@mmsqe