add comments to SendToEthereumHandler

crypto-org-chain · Oct 13, 2021 · ac8dd24 · ac8dd24
1 parent d021d14
commit ac8dd24
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/x/cronos/keeper/evm_hooks_test.go b/x/cronos/keeper/evm_hooks_test.go
@@ -125,7 +125,7 @@ func (suite *KeeperTestSuite) TestEvmHooks() {
 			},
 		},
 		{
-			"fail send to ethereum",
+			"fail send to ethereum", // gravity feature is removed
 			func() {
 				suite.SetupTest()
 				denom := "gravity0x0000000000000000000000000000000000000000"

diff --git a/x/cronos/keeper/evm_log_handlers.go b/x/cronos/keeper/evm_log_handlers.go
@@ -173,6 +173,9 @@ func (h SendToEthereumHandler) EventID() common.Hash {
 	return SendToEthereumEvent.ID
 }
 
+// Handle returns error unconditionally.
+// Since gravity bridge is removed and could be added later,
+// we keep this event handler, but returns error unconditionally to prevent accidental access.
 func (h SendToEthereumHandler) Handle(ctx sdk.Context, contract common.Address, data []byte) error {
 	return fmt.Errorf("native action %s is not implemented", SendToEthereumEventName)
 }