Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: potential concurrency-related bugs #682

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Dec 3, 2021

Solution: upgraded Cosmos SDK to 0.44.5 and Tendermint to 0.34.15
(and IAVL is upgraded to 0.17.3
which contains a fix https://github.com/cosmos/iavl/releases/tag/v0.17.3 )

Solution: upgraded Cosmos SDK to 0.44.5 and Tendermint to 0.34.15
(and IAVL is upgraded to 0.17.3
which contains a fix https://github.com/cosmos/iavl/releases/tag/v0.17.3 )
@tomtau
Copy link
Contributor Author

tomtau commented Dec 3, 2021

/runsim

@github-actions
Copy link

github-actions bot commented Dec 3, 2021

Simulation tests started and triggered by /runsim.
Will update here when it succeeds or fails.
Can further check progress here

@codecov
Copy link

codecov bot commented Dec 3, 2021

Codecov Report

Merging #682 (54ce6f8) into master (5f11d65) will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #682      +/-   ##
==========================================
- Coverage   22.42%   22.20%   -0.22%     
==========================================
  Files          70       71       +1     
  Lines        8134     8115      -19     
==========================================
- Hits         1824     1802      -22     
+ Misses       5769     5765       -4     
- Partials      541      548       +7     
Flag Coverage Δ
integration_tests 18.89% <ø> (-0.47%) ⬇️
unit_tests 9.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
x/nft/types/codec.go 50.00% <0.00%> (-16.67%) ⬇️
x/nft/keeper/querier.go 8.67% <0.00%> (-11.33%) ⬇️
app/app.go 9.21% <0.00%> (-8.56%) ⬇️
x/nft/types/msgs.go 48.14% <0.00%> (-8.38%) ⬇️
app/params/proto.go 100.00% <0.00%> (ø)
cmd/chain-maind/main.go 0.00% <0.00%> (ø)
x/nft/simulation/genesis.go 0.00% <0.00%> (ø)
x/nft/simulation/operations.go 0.00% <0.00%> (ø)
x/nft/types/events.go 100.00% <0.00%> (ø)
x/nft/types/tx.pb.go 22.77% <0.00%> (+2.26%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f11d65...54ce6f8. Read the comment docs.

@tomtau tomtau requested a review from damoncro December 3, 2021 02:19
@github-actions
Copy link

github-actions bot commented Dec 3, 2021

/runsim simulation test has succeeded 🎉
Can further check here

@damoncro
Copy link
Contributor

damoncro commented Dec 3, 2021

Question: Is codecov/project test result necessary to consider to be passed?

@tomtau
Copy link
Contributor Author

tomtau commented Dec 3, 2021

Question: Is codecov/project test result necessary to consider to be passed?

until this #278 is resolved, it's not that reliable, so not for now, but good to look into if there are some Go source code changes

@tomtau tomtau merged commit 72b6f6e into crypto-org-chain:master Dec 3, 2021
This was referenced Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants