This repository has been archived by the owner on Jul 27, 2022. It is now read-only.
Problem (CRO-627) council node pubkey format different from tendermint #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yihuang
requested review from
calvinaco,
devashishdxt and
tomtau
as code owners
|
Oh, this one needs to wait for #651 |
tomtau
suggested changes
Dec 6, 2019
chain-core/src/state/tendermint.rs
Outdated
| let bytes = base64::decode(String::deserialize(deserializer)?.as_bytes()) | ||
| .map_err(|e| D::Error::custom(format!("{}", e)))?; | ||
| let mut result = [0u8; PUBLIC_KEY_SIZE]; | ||
| result.copy_from_slice(&bytes); |
There was a problem hiding this comment.
copy_from_slice will panic if the lengths don't match, so ideally before this, there should be a check on bytes.len() == PUBLIC_KEY_SIZE
There was a problem hiding this comment.
also perhaps just deserialise the string and then call TendermintValidatorPubKey::from_base64 ?
There was a problem hiding this comment.
Fixed, also brings in thiserror crate, looks like a decent way to handle error type hierarchies.
chain-core/src/state/tendermint.rs
Outdated
| #[cfg(feature = "base64")] | ||
| pub fn from_base64(bytes: &[u8]) -> Result<TendermintValidatorPubKey, base64::DecodeError> { | ||
| let mut result = [0u8; PUBLIC_KEY_SIZE]; | ||
| result.copy_from_slice(&base64::decode(bytes)?); |
There was a problem hiding this comment.
copy_from_slice will panic if the lengths don't match, so ideally before this, there should be a check on bytes.len() == PUBLIC_KEY_SIZE
Codecov Report
@@ Coverage Diff @@
## master #657 +/- ##
==========================================
- Coverage 70.17% 70.14% -0.04%
==========================================
Files 133 133
Lines 16384 16374 -10
==========================================
- Hits 11497 11485 -12
- Misses 4887 4889 +2
|
|
bors try |
tryBuild failed |
Solution: - serialize TendermintValidatorPubKey same as tendermint. - Remove ValidatorPubkey in favor of TendermintValidatorPubKey
|
Fixed the integration test script error. |
|
bors retry |
tryBuild succeeded |
Build failed |
|
bors retry |
Build failed |
|
bors retry |
Build failed |
|
bors retry |
bors bot
added a commit
that referenced
this pull request
Dec 9, 2019
657: Problem (CRO-627) council node pubkey format different from tendermint r=tomtau a=yihuang Solution: - serialize TendermintValidatorPubKey the same as tendermint. - Remove ValidatorPubkey in favor of TendermintValidatorPubKey. 658: Problem: monetary expansion calculation could panic for misconfigration r=tomtau a=yihuang Solution: - Checked the arithemetic error, when happends print a warning and don't mint new coins. Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution: