Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: confusing and incorrect history display #846

Closed
tomtau opened this issue Jan 7, 2020 · 3 comments
Closed

Problem: confusing and incorrect history display #846

tomtau opened this issue Jan 7, 2020 · 3 comments
Assignees
@yihuang @tomtau @calvinaco @devashishdxt @linfeng-crypto
Labels
bug Something isn't working
Milestone
CRO Sprint 23

Comments

@tomtau
Copy link
Contributor

tomtau commented Jan 7, 2020 •
edited
Loading

in client-cli (perhaps similar issue is in client-rpc), deposit tx will be shown as "out", amount: "0.00000000", fee: "the amount deposited".

If one does a transfer of any amount within the same wallet, the display is logical, as it'll show as "out", amount: "0.00000000", fee: "real fee".

It'll be useful to display transaction types + have some command for a detailed transaction view; or any other ideas?
@tomtau tomtau added the bug Something isn't working label Jan 7, 2020
@devashishdxt devashishdxt mentioned this issue Jan 7, 2020
Merged
bors bot added a commit that referenced this issue Jan 8, 2020
@bors @devashishdxt
Merge #848
4053a2d 
848: Problem: Client CLI does not show transaction type in history r=tomtau a=devashishdxt

Solution: Show transaction type in history. This addresses a part of #846

Sample output after this change:
```
+------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+
| Transaction ID                                                   | In/Out | Amount               | Fee | Transaction Type | Block Height | Block Time                     |
+------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+
| cc88d0ca2cbcd6ce167a6db426f40c3da034deb5b4e4f09e5ec01f39af80c0ea | IN     | 24999999999.99999703 |   - | Withdraw         |           92 | 2020-01-07T10:14:17.764748000Z |
+------------------------------------------------------------------+--------+----------------------+-----+------------------+--------------+--------------------------------+
```

Co-authored-by: Devashish Dixit <devashish@crypto.com>
@tomtau tomtau added this to the CRO Sprint 22 milestone Jan 9, 2020
@tomtau
Copy link
Contributor Author

tomtau commented Jan 9, 2020

fee can be taken from block_results, as there's an event with the actual fee paid: https://github.com/crypto-com/chain/blob/master/chain-abci/src/app/mod.rs#L357

This was referenced Jan 20, 2020
Closed
Closed
@tomtau tomtau modified the milestones: CRO Sprint 22, CRO Sprint 23 Jan 22, 2020
@tomtau
Copy link
Contributor Author

tomtau commented Jan 30, 2020

one other related issue to display: #929

@tomtau
Copy link
Contributor Author

tomtau commented Jan 30, 2020

I put the transaction details in a separate issue: #968

tomtau added a commit to tomtau/chain that referenced this issue Jan 30, 2020
@tomtau
Problem: incorrect fee display in history (crypto-com#846)
bca72cf 
Solution:
- removed the "balance change" output custom fee calculation / deduction
- added paid fee to the balance change that's directly taken from events / attributes

Note: transaction details was moved to a separate issue: crypto-com#968
@tomtau tomtau mentioned this issue Jan 30, 2020
Merged
tomtau added a commit to tomtau/chain that referenced this issue Jan 30, 2020
@tomtau
Problem: incorrect fee display in history (fix crypto-com#846)
0a733dc 
Solution:
- removed the "balance change" output custom fee calculation / deduction
- added paid fee to the balance change that's directly taken from events / attributes

Note: transaction details was moved to a separate issue: crypto-com#968
bors bot added a commit that referenced this issue Jan 30, 2020
@bors @tomtau
Merge #969
028d8be 
969: Problem: incorrect fee display in history (#846) r=tomtau a=tomtau

Solution:
- removed the "balance change" output custom fee calculation / deduction
- added paid fee to the balance change that's directly taken from events / attributes

Note: transaction details was moved to a separate issue: #968

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
bors bot added a commit that referenced this issue Jan 30, 2020
@bors @tomtau
Merge #969
e7356b8 
969: Problem: incorrect fee display in history (#846) r=tomtau a=tomtau

Solution:
- removed the "balance change" output custom fee calculation / deduction
- added paid fee to the balance change that's directly taken from events / attributes

Note: transaction details was moved to a separate issue: #968

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
bors bot added a commit that referenced this issue Jan 30, 2020
@bors @tomtau
Merge #969
2779654 
969: Problem: incorrect fee display in history (#846) r=tomtau a=tomtau

Solution:
- removed the "balance change" output custom fee calculation / deduction
- added paid fee to the balance change that's directly taken from events / attributes

Note: transaction details was moved to a separate issue: #968

Co-authored-by: Tomas Tauber <2410580+tomtau@users.noreply.github.com>
@bors bors bot closed this as completed in 5348011 Jan 30, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

@tomtau tomtau

@calvinaco calvinaco

@devashishdxt devashishdxt

@linfeng-crypto linfeng-crypto

Labels
bug Something isn't working
Projects
None yet
Milestone
CRO Sprint 23
Development

No branches or pull requests
5 participants
@yihuang @tomtau @calvinaco @devashishdxt @linfeng-crypto