Skip to content
This repository has been archived by the owner on Jul 27, 2022. It is now read-only.

Problem: incorrect generated withdraw transaction with an extra view key #840

Closed
tomtau opened this issue Jan 7, 2020 · 2 comments · Fixed by #841
Closed

Problem: incorrect generated withdraw transaction with an extra view key #840

tomtau opened this issue Jan 7, 2020 · 2 comments · Fixed by #841
Assignees
@yihuang @devashishdxt @leejw51crypto @linfeng-crypto
Labels
bug Something isn't working

Comments

@tomtau
Copy link
Contributor

tomtau commented Jan 7, 2020

It seems the estimated fee for a withdraw transaction is not correct if an extra view key is included, as it'll fail with input-output coin sum mismatch error
@tomtau tomtau added the bug Something isn't working label Jan 7, 2020
@tomtau
Copy link
Contributor Author

tomtau commented Jan 7, 2020

Or another detail was that I didn't run sync when creating the transaction

@devashishdxt devashishdxt mentioned this issue Jan 7, 2020
Merged
@tomtau
Copy link
Contributor Author

tomtau commented Jan 7, 2020

this may be fixed #841 but re-open if it was not

bors bot added a commit that referenced this issue Jan 7, 2020
@bors @yihuang
@devashishdxt @linfeng-crypto
Merge #830 #841 #843
5c01883 
830: Problem(Fix #786): client keeps re-deriving hardened key r=tomtau a=yihuang

Solution:
- derive hmaced-keys only when create wallet,
  client pass it around.

* Use blake2 of wallet name as salt of argon2.

841: Problem: User may enter same view key multiple times in client-cli r=tomtau a=devashishdxt

Solution: Used `BTreeSet` instead of `Vec`. Fixes #840

843: Problem:(Fix #832) random client failing if node didn't store historical state data r=tomtau a=linfeng-crypto

issue: #832 

solution: each time when chain-abci start, check the last app states stored in `COL_APP_STATES` to force to store historical state data or not.


Co-authored-by: yihuang <yi.codeplayer@gmail.com>
Co-authored-by: Devashish Dixit <devashish@crypto.com>
Co-authored-by: linfeng <linfeng@crypto.com>
@bors bors bot closed this as completed in 47825f1 Jan 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yihuang yihuang

@devashishdxt devashishdxt

@leejw51crypto leejw51crypto

@linfeng-crypto linfeng-crypto

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem: User may enter same view key multiple times in client-cli
5 participants
@yihuang @tomtau @devashishdxt @leejw51crypto @linfeng-crypto