Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(http): update health endpoint to include cryostatVersion #1671

Merged
merged 1 commit into from
Sep 15, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Sep 15, 2023

Welcome to Cryostat! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to #852

Description of the change:

Update HTTP doc to include cryostatVersion in the response for the /health endpoint.

Motivation for the change:

See: https://github.com/cryostatio/cryostat-web/blob/ee99ad168f707e4342444589a466f9abb0ca6599/src/app/Shared/Services/Api.service.tsx#L1626

Signed-off-by: Thuan Vo <thuan.votann@gmail.com>
@tthvo tthvo added the docs label Sep 15, 2023
@github-actions
Copy link
Contributor

Hi @tthvo! Add at least one of the required labels to this PR

Required labels are : chore,ci,cleanup,docs,feat,fix,perf,refactor,style,test

@tthvo tthvo requested a review from andrewazores September 15, 2023 19:32
@tthvo tthvo changed the title doc(http): update health endpoint to include cryostatVersion docs(http): update health endpoint to include cryostatVersion Sep 15, 2023
@andrewazores andrewazores merged commit bf4cfb7 into cryostatio:main Sep 15, 2023
@tthvo tthvo deleted the health-doc branch September 15, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants