Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(secret): use release name in database secret #65

Merged
merged 1 commit into from
May 31, 2023
Merged

fix(secret): use release name in database secret #65

merged 1 commit into from
May 31, 2023

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented May 25, 2023

Fixes #62

Prefix secret name with release's name to avoid conflicts with other releases in the same namespace.

@tthvo tthvo added the fix label May 25, 2023
@tthvo tthvo requested review from andrewazores and ebaron May 25, 2023 04:35
andrewazores
andrewazores previously approved these changes May 25, 2023
View reviewed changes
@tthvo
fix(secret): use release name in database secret
af75a54 
Signed-off-by: Thuan Vo <thvo@redhat.com>
@tthvo
Copy link
Member Author

tthvo commented May 29, 2023

Forgot to update CRYOSTAT_JMX_CREDENTIALS_DB_PASSWORD env var. Updated now :))

ebaron
ebaron approved these changes May 31, 2023
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ebaron ebaron merged commit e06dfb2 into cryostatio:main May 31, 2023
mergify bot pushed a commit that referenced this pull request May 31, 2023
@tthvo @mergify
fix(secret): use release name in database secret (#65)
5001cb5 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit e06dfb2)
@mergify mergify bot mentioned this pull request May 31, 2023
Merged
ebaron pushed a commit that referenced this pull request May 31, 2023
@mergify @tthvo
fix(secret): use release name in database secret (#65) (#67)
47c79b0 
Signed-off-by: Thuan Vo <thvo@redhat.com>
(cherry picked from commit e06dfb2)

Co-authored-by: Thuan Vo <thvo@redhat.com>
@tthvo tthvo deleted the crd-db branch June 20, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@andrewazores andrewazores andrewazores left review comments

Assignees
No one assigned
Labels
backport fix
Projects
No open projects
2.4.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Use release name for credentials secret
3 participants
@tthvo @andrewazores @ebaron