Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(chart): specify kubeVersion constraints #47

Merged
merged 1 commit into from
Nov 3, 2022
Merged

chore(chart): specify kubeVersion constraints #47

merged 1 commit into from
Nov 3, 2022

Conversation

tthvo
Copy link
Member

@tthvo tthvo commented Nov 3, 2022

Fixes #45

Specified k8s version constraint in Chart.yaml.

Reference: https://helm.sh/docs/topics/charts/#the-kubeversion-field

@tthvo tthvo added the chore Refactor, rename, cleanup, etc. label Nov 3, 2022
@tthvo tthvo requested review from andrewazores and ebaron November 3, 2022 22:54
ebaron
ebaron approved these changes Nov 3, 2022
View reviewed changes
Copy link
Member

@ebaron ebaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ebaron ebaron added the backport label Nov 3, 2022
@ebaron ebaron merged commit 6790773 into cryostatio:main Nov 3, 2022
mergify bot pushed a commit that referenced this pull request Nov 3, 2022
@tthvo @mergify
chore(chart): specify kubeVersion constraints (#47)
416c58b 
(cherry picked from commit 6790773)

# Conflicts:
#	cryostat/Chart.yaml
@mergify mergify bot mentioned this pull request Nov 3, 2022
Merged
ebaron added a commit that referenced this pull request Nov 3, 2022
@mergify @tthvo @ebaron
chore(chart): specify kubeVersion constraints (backport #47) (#48)
46d2b10 
* chore(chart): specify kubeVersion constraints (#47)

(cherry picked from commit 6790773)

# Conflicts:
#	cryostat/Chart.yaml

* Fix conflicts

Co-authored-by: Thuan Vo <thvo@redhat.com>
Co-authored-by: Elliott Baron <ebaron@redhat.com>
@tthvo tthvo deleted the kubeversion branch November 3, 2022 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ebaron ebaron ebaron approved these changes

@andrewazores andrewazores Awaiting requested review from andrewazores

Assignees
No one assigned
Labels
backport chore Refactor, rename, cleanup, etc.
Projects
No open projects
2.3.0 release
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chart.yaml should include kubeVersion
2 participants
@tthvo @ebaron