-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store go module name in var in Makefile #1989
Store go module name in var in Makefile #1989
Conversation
@junnhy5: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
@junnhy5: There are no area labels on this PR. You can add as many areas as you see fit.
DetailsI am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository. |
/area configuration Thank you for the pull request! yes this can be merged. Thank you! |
@LaurenceJJones merging is blocked by the CI 😌 |
GO_MODULE_NAME = "github.com/crowdsecurity/crowdsec" you have to remove the quotes: GO_MODULE_NAME=github... |
For a question of cleanliness and if the project will evolve in the future at the level of the not (even if there is little chance that it is the case), to store the name of the module in a variable and call it then. 😊