Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store go module name in var in Makefile #1989

Merged

Conversation

juhnny5
Copy link
Contributor

@juhnny5 juhnny5 commented Jan 13, 2023

For a question of cleanliness and if the project will evolve in the future at the level of the not (even if there is little chance that it is the case), to store the name of the module in a variable and call it then. 😊

@github-actions
Copy link

@junnhy5: There are no 'kind' label on this PR. You need a 'kind' label to generate the release automatically.

  • /kind feature
  • /kind enhancement
  • /kind fix
  • /kind chore
  • /kind dependencies
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@github-actions
Copy link

@junnhy5: There are no area labels on this PR. You can add as many areas as you see fit.

  • /area agent
  • /area local-api
  • /area cscli
  • /area security
  • /area configuration
Details

I am a bot created to help the crowdsecurity developers manage community feedback and contributions. You can check out my manifest file to understand my behavior and what I can do. If you want to use this for your project, you can check out the BirthdayResearch/oss-governance-bot repository.

@LaurenceJJones
Copy link
Contributor

LaurenceJJones commented Jan 13, 2023

/area configuration
/kind enhancement

Thank you for the pull request! yes this can be merged. Thank you!

@juhnny5
Copy link
Contributor Author

juhnny5 commented Jan 13, 2023

@LaurenceJJones merging is blocked by the CI 😌

@mmetc
Copy link
Contributor

mmetc commented Jan 15, 2023

GO_MODULE_NAME = "github.com/crowdsecurity/crowdsec"

you have to remove the quotes: GO_MODULE_NAME=github...

@mmetc mmetc merged commit 83ed8a6 into crowdsecurity:master Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants