Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention WAF in appsec doc ahead of WAF articles #633

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

rr404
Copy link
Contributor

@rr404 rr404 commented Oct 8, 2024

Changes in titles and sidebar only for this section : https://pr-633.d1to60jd2gb6y6.amplifyapp.com/docs/next/appsec/intro

@rr404 rr404 changed the title Mention WAf in appsec doc ahead of WAF articles Mention WAF in appsec doc ahead of WAF articles Oct 8, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-633.d1to60jd2gb6y6.amplifyapp.com

Copy link
Contributor

@LaurenceJJones LaurenceJJones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NGL I won't accept any wording that places "CrowdSec WAF" together as that is not the name of the component and just causes confusion. I agree with wording that describes the appsec component as a WAF.

@rr404 rr404 merged commit b232e82 into main Oct 9, 2024
2 checks passed
@rr404 rr404 deleted the jdv-mention-waf-in-appsec-doc-and-more branch October 9, 2024 07:49
@rr404
Copy link
Contributor Author

rr404 commented Oct 9, 2024

NGL I won't accept any wording that places "CrowdSec WAF" together as that is not the name of the component and just causes confusion. I agree with wording that describes the appsec component as a WAF.

I'm doing it to serve the article coming up.
I need that when someone type WAF in the doc, they get something else than AWS WAF

We'll find a more permanent change later. much work to do on that appSec doc anyways, it's quite a mess now I'm re-reading it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants