Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Socket subscribe improvements #285

Merged
merged 3 commits into from
Feb 18, 2025
Merged

Conversation

MykhailoNester
Copy link
Collaborator

  • add new API request for ticket data;
  • provide ticket data with socket events;

@MykhailoNester MykhailoNester added the enhancement New feature or request label Jan 31, 2025
@MykhailoNester MykhailoNester self-assigned this Jan 31, 2025
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 6.89655% with 54 lines in your changes missing coverage. Please review.

Project coverage is 57.85%. Comparing base (f318b22) to head (480c7dc).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...main/java/com/crowdin/platform/data/DataManager.kt 0.00% 22 Missing ⚠️
...n/platform/realtimeupdate/EchoWebSocketListener.kt 19.05% 17 Missing ⚠️
...m/crowdin/platform/data/model/TicketRequestBody.kt 0.00% 7 Missing ⚠️
.../crowdin/platform/data/model/TicketResponseBody.kt 0.00% 4 Missing ⚠️
...crowdin/platform/data/remote/CrowdingRepository.kt 0.00% 3 Missing ⚠️
...n/platform/realtimeupdate/RealTimeUpdateManager.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #285      +/-   ##
============================================
- Coverage     59.32%   57.85%   -1.46%     
+ Complexity      376      375       -1     
============================================
  Files            57       58       +1     
  Lines          2008     2033      +25     
  Branches        316      323       +7     
============================================
- Hits           1191     1176      -15     
- Misses          598      639      +41     
+ Partials        219      218       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MykhailoNester MykhailoNester marked this pull request as ready for review February 16, 2025 16:59
@andrii-bodnar andrii-bodnar merged commit ffcdf3b into master Feb 18, 2025
5 checks passed
@andrii-bodnar andrii-bodnar deleted the task/socket-event-updates branch February 18, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants