Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUR package: remove gradle dependency usage #359

Merged
merged 1 commit into from
Apr 30, 2021

Conversation

cmrd-senya
Copy link
Contributor

@cmrd-senya cmrd-senya commented Apr 30, 2021

Arch Linux updated Gradle to version 7 and crowdin-cli doesn't build with this version yet (fails with an error).

Looks like we can just call gradlew script instead of a 3rd party provided Gradle installation, which will pull the right version of Gradle for the project.

P.S. I've already pushed this changed to AUR

@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #359 (af43533) into cli3 (5725164) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               cli3     #359   +/-   ##
=========================================
  Coverage     58.49%   58.49%           
  Complexity      856      856           
=========================================
  Files           143      143           
  Lines          4148     4148           
  Branches        590      590           
=========================================
  Hits           2426     2426           
  Misses         1434     1434           
  Partials        288      288           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5725164...af43533. Read the comment docs.

@andrii-bodnar
Copy link
Member

@cmrd-senya thanks a lot for your contribution! 🎉

I could not understand the reason for today's CI error in the package publication, even created an issue in the github-actions-deploy-aur repo 😄

Now everything is clear, thank you!

@andrii-bodnar andrii-bodnar merged commit 61d8fbb into crowdin:cli3 Apr 30, 2021
@cmrd-senya cmrd-senya deleted the update-pkgbuild branch April 30, 2021 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants