Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new function - download targets and pseudolocalization #316

Merged
merged 12 commits into from
Nov 9, 2020

Conversation

frombetelgeuse
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Oct 13, 2020

Codecov Report

Merging #316 into cli3 will decrease coverage by 1.11%.
The diff coverage is 57.17%.

Impacted file tree graph

@@             Coverage Diff              @@
##               cli3     #316      +/-   ##
============================================
- Coverage     64.19%   63.09%   -1.10%     
- Complexity      420      778     +358     
============================================
  Files            57      133      +76     
  Lines          1815     3413    +1598     
  Branches        258      493     +235     
============================================
+ Hits           1165     2153     +988     
- Misses          515     1016     +501     
- Partials        135      244     +109     
Impacted Files Coverage Δ Complexity Δ
src/main/java/com/crowdin/cli/Cli.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...om/crowdin/cli/client/ExistsResponseException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
.../com/crowdin/cli/client/WaitResponseException.java 100.00% <ø> (ø) 1.00 <0.00> (?)
...in/cli/commands/actions/DownloadTargetsAction.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...din/cli/commands/functionality/DryrunBranches.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../cli/commands/functionality/TranslationsUtils.java 75.87% <ø> (-5.21%) 9.00 <0.00> (-3.00)
...com/crowdin/cli/commands/picocli/CommandNames.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...java/com/crowdin/cli/properties/AllProperties.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../crowdin/cli/properties/BasePropertiesBuilder.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...owdin/cli/properties/PropertiesBuilderChecker.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
... and 207 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77c9e96...275b262. Read the comment docs.

- make building commands more flexible;
- Separate logic for building properties;
- Break the Client into smaller classes;
- Make core classes for constructing commands more abstract.
@frombetelgeuse frombetelgeuse changed the title Add new function - download targets WIP Add new function - download targets Oct 26, 2020
@andrii-bodnar andrii-bodnar linked an issue Oct 28, 2020 that may be closed by this pull request
@andrii-bodnar andrii-bodnar changed the title Add new function - download targets Add new function - download targets and pseudolocalization Oct 28, 2020
@andrii-bodnar andrii-bodnar merged commit 8b41ba6 into cli3 Nov 9, 2020
@andrii-bodnar andrii-bodnar deleted the download-targets branch November 9, 2020 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to download pseudotranslations
2 participants