Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css: Darken Light Theme $good-color, and Use It #2877

Closed
wants to merge 2 commits into from

Conversation

phroggster
Copy link
Collaborator

Description of the Change

My second step into the depths of CSS.

  • Darkened the light theme $good-color from #90ee90 to #10a010.
  • Added $good-color to restore backup modal success icon.
  • Changed connection panel background from lightgreen to $good-color
  • Changed (un)paused table-alt background from lightgreen to $good-color
  • I DID NOT TEST CHANNEL POINT REWARDS INDICATOR, AS I'M NOT AFFILIATED.
    • But those were impacted by this, and I'm blindly pushing it up regardless.

Applicable Issues

N/A

Testing

THIS NEEDS FURTHER TESTING

Tested as thoroughly as possible. However, I can not verify that the change in channel point rewards status icon color is appropriate.

Screenshots

Connection Status Icons:
status icons

Command Status Icons:
command status

Backup Restoration Successful:
restore success

- Darkened the light theme $good-color from #90ee90 to #10a010.
- Added $good-color to restore backup modal success icon.
- Changed connection panel background from lightgreen to $good-color
- Changed (un)paused table-alt background from lightgreen to $good-color
- DID NOT TEST CHANNEL POINT REWARDS INDICATOR, AS I'M NOT AFFILIATED.
  - But it was impacted by this, and I'm blindly pushing it up.
@phroggster
Copy link
Collaborator Author

I'm going to hit cancel on this PR, and switch from using $good-color to using a bespoke color for my CSS part 3 patch. Will revisit the ancillary changes after that has been submitted.

@phroggster phroggster closed this Oct 28, 2024
@phroggster phroggster deleted the css_good_color branch October 30, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant