tempest: Fix Heat flavor id #2099
Conversation
ID 8 was already used in nova cookbook. Taking 20 to leave some space for the future (and skip 13).
skazi0
force-pushed
the
tempest-heat-flavor
branch
from
eb9a4df
to
62d9142
Compare
| @@ -278,7 +278,7 @@ | |||
|
|
|||
| flavor_ref = "6" | |||
| alt_flavor_ref = "7" | |||
| heat_flavor_ref = "8" | |||
| heat_flavor_ref = "20" | |||
There was a problem hiding this comment.
Can't we use openstack flavor create which doesn't seem to require this thing?
There was a problem hiding this comment.
Something like openstack flavor create -c id -f value --ram 128 --disk 0 --vcpus 1 myflavor (and this way we get the id automatically)
There was a problem hiding this comment.
nova flavor-create auto does the same. I think the point here is that we have fixed IDs which need to be placed in config files and we don't need to look them up after creation.
There was a problem hiding this comment.
Right, but the problem seems to be that these fixed IDs may conflict, so I was wondering why not avoid the conflict altogether.
I guess it's fine to do the minimal change for now, but if we don't need fixed IDs, it's probably best to stop using them in the future.
There was a problem hiding this comment.
Agree. I just followed the "broken windows" pattern :o)
ID 8 was already used in nova cookbook.
Taking 20 to leave some space for the future (and skip 13).