neutron: enable designate integration #2095
Conversation
|
But is the neutron barclamp creating the ext-net ? If so you need to see the dns_name on that network. Is that also being done? And are you using the ml2 driver? that is another step needed. |
|
Thanks for input, I was not aware of these steps. let me wip this |
|
there is a pending XXX for this for floating (this is the name of ext-net) |
|
What is a "pending XXX"? |
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| @@ -445,3 +445,27 @@ | |||
| only_if { ha_enabled } | |||
| end | |||
| end | |||
|
|
|||
| floating_dns_domain = node[:neutron][:floating_dns_domain] | |||
There was a problem hiding this comment.
put all of this in post_install_conf after the floating etc is being created? otherwise execution order might be wrong.
| @@ -64,6 +64,13 @@ def fetch_rabbitmq_settings(barclamp=@cookbook_name) | |||
| end | |||
|
|
|||
| class CrowbarOpenStackHelper | |||
| def self.config_for_role_exists?(name) | |||
| shouldbe = "#{name}-config-" | |||
| @cached_roles = @cached_roles || Chef::Role.list.keys | |||
There was a problem hiding this comment.
Style/SelfAssignment: Use self-assignment shorthand ||=. (https://github.com/bbatsov/ruby-style-guide#self-assignment)
|
Interesting. i just looked at what Sumit's got and that config section lacked domain information. Upon further investigation we stumbled upon this little gem: tl;dr: the Designate integration in Neutron does not support Keystone V2. We'll try to come up with a patch. |
@jgrassler I think you can just set the domain info and set |
|
Yes, just use auth_type=password and set user_domain_name and project_domain_name |
|
This should be ready for reviews ! |
|
|
||
| execute "update_dns_domain_for_floating_network" do | ||
| command "#{env} neutron net-update floating --dns-domain #{domain_floating}" | ||
| not_if "#{openstack_cmd} network show floating -f value -c dns_domain | grep -q #{domain_floating}" |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [101/100] (https://github.com/SUSE/style-guides/blob/master/Ruby.md#metricslinelength)
sjamgade
force-pushed
the
rocky_neutron
branch
2 times, most recently
from
aa52e85
to
43c7e2c
Compare
chef/data_bags/crowbar/migrate/neutron/306_fix_domains_names.rb
Outdated
Show resolved
Hide resolved
chef/data_bags/crowbar/migrate/neutron/306_fix_domains_names.rb
Outdated
Show resolved
Hide resolved
The config enabled by the flag lets neutron create dns records when floating ip are created and assigned. (flag: designate_enabled) The config was previously added but was not enabled as the barclamp was still under development. Add designate public url to the config.[1] Set domain name for fixed and floating network. This allows neutron to assign correct dns domain to the port as they are created. There is more information at [1]. This is mainly needed when integrating neutron with external dns service (designate). Using the neutron cli to net-update as openstack cli does not support it (`openstack help network set` has no option for dns-domain) Fixed a typo in template for neutron as domains are expected to end with a dot(.) [1] https://docs.openstack.org/ocata/networking-guide/config-dns-int.html
| @@ -119,6 +119,17 @@ | |||
| infoblox_settings = neutron[:neutron][:infoblox] | |||
| end | |||
|
|
|||
| designate_public_uri = nil | |||
| designate_server = node_search_with_cache("roles:designate-server").first | |||
There was a problem hiding this comment.
What if there are multiple nodes, as in an HA case?
There was a problem hiding this comment.
That doesn't pose a problem: we just need a node object for any node with the designate role. A little further down we invoke CrowbarHelper.get_host_for_public_url() on that node object and that function will Do The Right Thing on an HA cloud and yield the HA cluster's public host (I've checked in QA's HA enabled test environment).
This reverts commit 64e7ad9. We've are very close to the release and have multiple pull requests still open for Designate: * crowbar#2095 * crowbar#2104 * crowbar#2105 * SUSE-Cloud/doc-cloud#931 There are way too many question marks on this so I am switching the barclamp back to invisible mode. Lets get these pull requests squared away carefully and without the rush of imminent release.
This reverts commit 64e7ad9. We've are very close to the release and have multiple pull requests still open for Designate: * crowbar#2095 * crowbar#2104 * crowbar#2105 * SUSE-Cloud/doc-cloud#931 There are way too many question marks on this so I am switching the barclamp back to invisible mode. Lets get these pull requests squared away carefully and without the rush of imminent release.
the config enabled by this flag lets neutron create dns records when
floating ip are created and assigned.
The config was previously added but was not enabled as the barclamp was
still under development
This config is not really needed for designate or neutron to work, but they help enable certain features
this is where the flag is used
crowbar-openstack/chef/cookbooks/neutron/templates/default/neutron.conf.erb
Lines 36 to 48 in a671c04