Windows: delete useless code of installing extensions #117
Conversation
|
@rakuco please help to review. |
|
@DonnaWuDongxia I had a different idea about this. pass the -k to the windows backend, and then keep the files. Will make a patch. |
|
Please look at #118 |
DonnaWuDongxia
changed the title
DonnaWuDongxia
changed the title
DonnaWuDongxia
changed the title
|
@r0b5t4 Please help to review, the useless code need to be deleted, otherwise there will be a bug. Thanks! |
|
@DonnaWuDongxia I think we should maybe print a warning if the extension folder is under the app folder, because that means the extensions will be included twice in the MSI. Once unused in the app, once copied to the extensions folder. |
| }.bind(this)); | ||
|
|
||
| // Skip in-folder extensions copying to avoid duplication. | ||
| // Because the needed extension files has already be installed by previous step. | ||
| installFiles(app_path, app_files_folder, this._manifest.extensions); |
There was a problem hiding this comment.
@r0b5t4 We have skipped the in-folder extensions when install the web staff into the installer. So there will be no dup.
|
@r0b5t4 We have skipped the in-folder extension folder in line 268 when installing the web staff into the installer. So there will be no dup. |
|
@DonnaWuDongxia sorry for the delay. We have the CI working now again, and the JIRA migration is done as well. So let's try to finish this. I think after the call to installExtensionDlls() we should still check if the extension dir is a subdir of the web app, and if it is, print a warning that the files will be duplicated. Thanks. |
|
@r0b5t4 With below line: Do you mean we don't use the "skip_array", but show warning log for in-folder extensions? |
No description provided.