This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fixes the unmarshal error for sensitive string type #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ulucinar
reviewed
Feb 18, 2022
|
|
||
| // This for loop accesses to value of selectorMap to determine whether the type is map. | ||
| func hasMapValue(selectorMap map[string]interface{}) bool { | ||
| for _, v := range selectorMap { |
There was a problem hiding this comment.
nit: As an alternative, we could use reflection here to get map's value type. But still that requires access to map's actual values, which means accessing a MapIterator.
Signed-off-by: Sergen Yalçın <yalcinsergen97@gmail.com>
sergenyalcin
force-pushed
the
fix-unmarshal-string
branch
from
1d374be to
0d855eb
Compare
ulucinar
approved these changes
Feb 21, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #236
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
This PR was tested by creating the resources that have three type as sensitive: string, []string, map[string]string