This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Fix reconciliation errors if a referenced secret is deleted #237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turkenh
reviewed
Feb 21, 2022
turkenh
reviewed
Feb 21, 2022
ezgidemirel
force-pushed
the
issue-216
branch
from
6242ca8 to
d5aa7ed
Compare
turkenh
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
Added some nitpicks, looking good otherwise!
Thank you @ezgidemirel!
Signed-off-by: ezgidemirel <ezgidemirel91@gmail.com>
ezgidemirel
force-pushed
the
issue-216
branch
from
d5aa7ed to
2de7b89
Compare
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: ezgidemirel ezgidemirel91@gmail.com
Description of your changes
Fixes #216
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
I replaced terrajet version consumed in
provider-jet-azureto this branch in my local environment and created a PostgreSqlDB resource. Once it's ready, I first deleted the k8s secret referenced byadministratorLoginPasswordSecretReffield and then deleted the MR.