This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Conversion: Default to string as element type #199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
turkenh
added a commit
to turkenh/provider-jet-rancher
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Hasan Turken <turkenh@gmail.com>
Yes, @ytsarev reported this with https://github.com/AbsaOSS/provider-jet-rancher |
|
Thanks for linking the issue. |
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
There could be some collection types which do not set types of their elements explicitly and we found out assuming
Stringin that case is the right way to go. We have implemented this in type builder but didn't follow same in conversion for resources using v1 sdk.This PR fixes the same issue in conversion package.
I have:
make reviewableto ensure this PR is ready for review.How has this code been tested
With provider rancher which uses v1 sdk.