This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
controller: set ongoing operation condition correctly #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncluded in a status update Signed-off-by: Muvaffak Onus <me@muvaf.com>
turkenh
approved these changes
Jan 6, 2022
2 tasks
|
/backport |
|
Backport failed for Please cherry-pick the changes locally. |
muvaf
added a commit
to muvaf/terrajet
that referenced
this pull request
Jan 7, 2022
…ncluded in a status update (crossplane#194) Signed-off-by: Muvaffak Onus <me@muvaf.com> (cherry picked from commit 47caf62)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
We don't request a status update after
Createcall, hence the ongoing condition is never applied. So I moved it toObservewhere we can set it whenever there is an ongoing operation.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually with RDS instance in jet-aws.