This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Add condition about running async operation #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: vaspahomov <vas2142553@gmail.com>
muvaf
reviewed
Jan 6, 2022
pkg/resource/conditions.go
Outdated
Comment on lines
29
to
30
| TypeAsyncOperation = "AsyncOperation" | ||
| TypeAsyncOperationFinished = "AsyncOperationFinished" |
There was a problem hiding this comment.
Maybe AsyncOperation for the ongoing one and LastAsyncOperation for the result of the finished one?
|
@vaspahomov Sorry for late review. We're planning a wave of releases starting with Terrajet. We can include this change if we can get it merged before EOD. |
Signed-off-by: vaspahomov <vas2142553@gmail.com>
vaspahomov
changed the title
muvaf
approved these changes
Jan 6, 2022
There was a problem hiding this comment.
Thanks @vaspahomov ! Have you got around to test this manually? Test section of the PR description seems missing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: vaspahomov vas2142553@gmail.com
Description of your changes
Added condition that notifies users about async operation is not finished yet.
Fixes #110
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.