This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
types: add type name to scope earlier #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alls see them, otherwise duplicates can be produced Signed-off-by: Muvaffak Onus <me@muvaf.com>
turkenh
approved these changes
Dec 29, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
I ran into a case where the resource name is
aws_cloudfront_monitoring_subscriptionand it has a field calledmonitoring_subscription. The type builder generatedMonitoringSubscriptionParametersandMonitoringSubscriptionObservationfields for both the main type and also its field. During printing, only one of them was printed which had no fields, hence we end up in the case where there is a singleMonitoringSubscriptionObservationthat has noIDfield, which brokeGetIDfunction.This change ensures that we add the generated type name to the package scope earlier so that look-ups in the recursive calls of the same type consider the name of the upper level type as well.
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually with Jet AWS.