This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Capitalize prefix/suffix acronyms in default resource config's kind name #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
muvaf
reviewed
Dec 16, 2021
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
turkenh
reviewed
Dec 17, 2021
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
turkenh
approved these changes
Dec 17, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
Fixes #178
In the default resource config, capitalize acronyms appearing as prefix/suffixes in kind names. For example, instead of
Serverid, we would like to have the default kind name asServerID.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
With
provider-jet-azureby generating resources from main branch.