This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Directions for calling ./hack/prepare.sh in the provider guide #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alper Rifat Ulucinar <ulucinar@users.noreply.github.com>
turkenh
approved these changes
Dec 3, 2021
|
Thank you @turkenh. |
muvaf
reviewed
Dec 3, 2021
| @@ -20,17 +20,11 @@ be quite similar for any other Terraform provider. | |||
| export ProviderNameUpper=GitHub | |||
| ``` | |||
|
|
|||
| 2. Replace all occurrences of `template` with your provider name: | |||
| 2. Run the `./hack/prepare.sh` script from repo root to prepare the repo, e.g., to | |||
There was a problem hiding this comment.
Looks like hack/prepare.sh wasn't committed.
There was a problem hiding this comment.
It lives in jet-template: https://github.com/crossplane-contrib/provider-jet-template/blob/main/hack/prepare.sh
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
In the context of crossplane-contrib/provider-jet-template#3, this change proposes to move repo preparation shell commands into the script
hack/prepare.shofcrossplane-contrib/provider-jet-template. This has some advantages like:hack/prepare.shscript incrossplane-contrib/provider-jet-template, the guide just instructs the user to call it.Depends on crossplane-contrib/provider-jet-template#9
I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Not a full test of the guide, however, tested by running
hack/prepare.shin crossplane-contrib/provider-jet-template#9.