This repository has been archived by the owner on Dec 15, 2022. It is now read-only.
Use explicit root directory so that generator can be run from anywhere #145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rmation so that generator can be run from anywhere. Signed-off-by: Muvaffak Onus <me@muvaf.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
This change lets the developer of the provider choose how they take the root dir by not enforcing an implicit contract by Terrajet like having to run it from the top level directory.
The main reason I wanted to do this is that I'd like to run
go run ../cmd/generator/main.gofromapis/generate.goand that won't work because the license header path is calculated as relative path.I have:
make reviewableto ensure this PR is ready for review.backport release-x.ylabels to auto-backport this PR if necessary.How has this code been tested
Manually with provider-tf-aws.