Unpack tool, its image and an example #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
|
Currently, this reads only YAML files. The stream piping each and every file is not feasible because we'd need to invent new file separators for different files and different types of files. I believe for additional Upbound metadata, we'll either need to build another binary or introduce a flag to this one that will read icons, ui-schemas etc directly from the filesystem rather than its stdin. It can use this binary to get all YAMLs or be completely separate. |
2 tasks
hasheddan
reviewed
Sep 18, 2020
Signed-off-by: Muvaffak Onus <onus.muvaffak@gmail.com>
|
@hasheddan thanks for the review! All your feedback should be addressed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the lean unpack tool which reads all Kubernetes YAMLs in the current directory recursively and prints them to stdout. For additional metadata processing, flags or different binaries and their images can be built.
@kasey I couldn't add you as reviewer, seems you're not member of crossplane-contrib org.
Fixes crossplane/crossplane#1714