Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't resolve references when being deleted #75

Merged
merged 1 commit into from
Nov 5, 2019

Commits on Nov 5, 2019

  1. Don't resolve references when being deleted

    Per the comment, there's too high a chance we'll get stuck and not process the
    delete because we reference resources that are also being deleted. I considered:
    
    * Processing references at delete time but not blocking on accessor errors. I
      felt this introduced too much complexity for little gain compared to just not
      trying resolution at all.
    * Making AttributeReferencers no-ops when the field they would set already had a
      value. I think this is an avenue we should investigate (issue forthcoming) but
      it is awkward to implement with the current AttributeReferencer interface.
    * Enforcing ordered deletes, such that a referenced resource cannot be deleted
      (at least not by Crossplane) until its referencers have all been deleted. This
      is the most bulletproof, but also the most complicated solution and would
      require further design investigation to pursue.
    
    Signed-off-by: Nic Cope <negz@rk0n.org>
    negz committed Nov 5, 2019
    Configuration menu
    Copy the full SHA
    29347c9 View commit details
    Browse the repository at this point in the history