Whitelist management policy Observe & Update #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hasan Turken <turkenh@gmail.com>
lsviben
reviewed
May 13, 2024
| @@ -85,6 +85,10 @@ func defaultSupportedManagementPolicies() []sets.Set[xpv1.ManagementAction] { | |||
| // Like ObserveOnly, but the external resource is deleted when the | |||
| // managed resource is deleted. | |||
| sets.New[xpv1.ManagementAction](xpv1.ManagementActionObserve, xpv1.ManagementActionDelete), | |||
| // No Crate and no Delete. Just update/patch the external resource. | |||
There was a problem hiding this comment.
Suggested change
| // No Crate and no Delete. Just update/patch the external resource. | |
| // No Create and no Delete. Just update/patch the external resource. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes
As initially requested in this ticket, we have valid use cases to set a management policy as "Observe & Update", at least with Provider Kubernetes.
This PR whitelisting this variant of management policies so that runtime will not fail early.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
With provider-kubernetes,
managementPolicies: ["Observe", "Update"].